Add inline CSS options #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to 1 task:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eligrey
commented
Oct 18, 2024
Comment on lines
+70
to
+71
| appContainer.appendChild(style); | ||
| attachToDoc(); |
There was a problem hiding this comment.
had to move stuff around to keep this optimal. we want to activate the stylesheet after setup for the external one, and activate it before setup for the inline one
There was a problem hiding this comment.
(hence the two orthogonal ifs with a between step instead of an if else)
There was a problem hiding this comment.
just wanted to ask this, makes sense
kate-kazantseva
previously approved these changes
Oct 18, 2024
eligrey
requested review from
kate-kazantseva
and removed request for
michaelfarrell76
kate-kazantseva
previously approved these changes
Oct 18, 2024
csmccarthy
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Security Implications
[none]
System Availability
[none]